rrthomas / pdfjam

The pdfjam package for manipulating PDF files
GNU General Public License v2.0
369 stars 27 forks source link

Avoid using `uname` with `-o` option #70

Closed lemniscati closed 1 year ago

lemniscati commented 1 year ago
rrthomas commented 1 year ago

Thanks for this. My understanding is that uname with no argument is the same as uname -s, which prints the kernel name. Does that indeed print Cygwin on Cygwin? (Sorry if you've already confirmed that it works!)

lemniscati commented 1 year ago

Thank you for consideration.

On my cygwin environment, uname behaves as follows:

$ uname
CYGWIN_NT-10.0-22621
$ uname -s
CYGWIN_NT-10.0-22621
$ uname -o
Cygwin
$

So, uname | grep -q CYGWIN is expected to be successful (exit status: 0) in Cygwin environments.

rrthomas commented 1 year ago

Looks good, thanks!