rrthomas / recode

Charset converter tool and library
GNU General Public License v3.0
130 stars 12 forks source link

Does not compile with glibc >= 2.28 #11

Closed blackPantherOS closed 6 years ago

blackPantherOS commented 6 years ago

Changes in glibc 2.28 will breaks this application build,

make all-recursive make[3]: Entering directory '/usr/src/RPM/BUILD/recode-3.7/lib' make[4]: Entering directory '/usr/src/RPM/BUILD/recode-3.7/lib' /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -D_REENTRANT -fPIC -MT fseterr.lo -MD -MP -MF .deps/fseterr.Tpo -c -o fseterr.lo fseterr.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -D_REENTRANT -fPIC -MT fseterr.lo -MD -MP -MF .deps/fseterr.Tpo -c fseterr.c -fPIC -DPIC -o .libs/fseterr.o fseterr.c: In function ‘fseterr’: fseterr.c:78:3: error: #error "Please port gnulib fseterr.c to your platform! Look at the definitions of ferror and clearerr on your system, then report this to bug-gnulib."

error "Please port gnulib fseterr.c to your platform! Look at the definitions of ferror and clearerr on your system, then report this to bug-gnulib."

^~~~~

rrthomas commented 6 years ago

Thanks for the heads up. The fix is to update gnulib. I will make a new source release with updated gnulib.

rrthomas commented 6 years ago

I've just pushed an update to gnulib that should fix this.

Could you possibly build from git master to check that it does?

blackPantherOS commented 6 years ago

I will check today, thank you

blackPantherOS commented 6 years ago

Okay now, the build is working fine new updated gnulib.

rrthomas commented 6 years ago

Thanks for confirming. I've released 3.7.1, with no other changes but the updated gnulib.