search

rrthomas / recode

Charset converter tool and library
GNU General Public License v3.0
130 stars 12 forks source link

tests fail on macOS when recode is not installed #12

Closed ryandesign closed 5 years ago

ryandesign commented 5 years ago

The tests fail on macOS if recode has not been installed, because it can't find the just-built shared library. tests/Makefile sets LD_LIBRARY_PATH to the library build directory, which is great for non-Mac operating systems, but macOS uses DYLD_LIBRARY_PATH for that purpose.

ryandesign commented 5 years ago

This fix works for me.

rrthomas commented 5 years ago

Thanks for this. Note that the patch is "really" required against Makefile.am.

ryandesign commented 5 years ago

For your use, certainly! For our use in MacPorts, we don't autoreconf here, which is why I patched Makefile.in.