search

rrthomas / recode

Charset converter tool and library
GNU General Public License v3.0
130 stars 12 forks source link

Test suite / make check runs no tests #20

Closed shlomif closed 4 years ago

shlomif commented 5 years ago

make check gives:

make[4]: Entering directory '/home/shlomif/Download/unpack/to-del/recode/tests'
make[5]: Entering directory '/home/shlomif/Download/unpack/to-del/recode/tests'
============================================================================
Testsuite summary for recode 3.7.1
============================================================================
# TOTAL: 0
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[5]: Leaving directory '/home/shlomif/Download/unpack/to-del/recode/tests'
make[4]: Leaving directory '/home/shlomif/Download/unpack/to-del/recode/tests'
make[3]: Leaving directory '/home/shlomif/Download/unpack/to-del/recode/tests'
make[2]: Leaving directory '/home/shlomif/Download/unpack/to-del/recode/tests'
make[1]: Leaving directory '/home/shlomif/Download/unpack/to-del/recode/tests'
Making check in contrib
make[1]: Entering directory '/home/shlomif/Download/unpack/to-del/recode/contrib'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/shlomif/Download/unpack/to-del/recode/contrib'
make[1]: Entering directory '/home/shlomif/Download/unpack/to-del/recode'
make[1]: Leaving directory '/home/shlomif/Download/unpack/to-del/recode'
[shlomif@telaviv1 recode]$

I'm on mageia v7 x86-64.

rrthomas commented 5 years ago

This is weird: the output looks like the output from an automake test suite, but recode doesn't use automake's test facility! When I run make check I get completely different output, from running the commands in tests/Makefile.am's check-local target.

The nesting, above, looks odd (levels 4/5): is some other Makefile being used?

shlomif commented 5 years ago

@rrthomas :

[shlomif@telaviv1 recode]$ make test
make: *** No rule to make target 'test'.  Stop.
$
rrthomas commented 5 years ago

Sorry, I meant make check. I've edited my previous comment.

shlomif commented 5 years ago

On Wed, 26 Jun 2019 13:14:22 -0700 Reuben Thomas notifications@github.com wrote:

Sorry, I meant make check.

ah. I see.

--

Shlomi Fish http://www.shlomifish.org/ http://is.gd/KNvczZ - The FSF Announces New Versions of the GPL

What does “IDK” stand for? I don’t know. — http://www.shlomifish.org/humour.html

Please reply to list if it's a mailing list post - http://shlom.in/reply .

rrthomas commented 4 years ago

I have been able to reproduce this behaviour, but I am not sure exactly how: what happens is that bootstrap overwrites tests/Makefile.am.

I think that this is fixed however with a newer version of bootstrap, so closing. Do re-open if you come across this behaviour again!