search

rrthomas / recode

Charset converter tool and library
GNU General Public License v3.0
130 stars 12 forks source link

Expand tabs #43

Closed kugland closed 1 year ago

kugland commented 1 year ago

The source code previously used a mix of tabs and spaces for identation, which made everything look off when using an editor configured with tab width != 8.

Since effective identation width used in the source is 2, I think it is reasonable to just expand everything to spaces.

Also, since the identation width is 2, some editors will automatically detect the tab width to be 2.

Another option would be to add vim modelines or an .editorconfig file.

rrthomas commented 1 year ago

Thanks for working on this! I'd prefer an .editorconfig file, as while it is nicer to have only spaces, the diff makes git history harder to read.