search

rrutsche / react-parallax

A React Component for parallax effect
MIT License
855 stars 76 forks source link

added bgImageSrcSet prop #42

Closed carterchung closed 6 years ago

carterchung commented 6 years ago

Feel free to decline and do it your own way (naming conventions, etc.), of course -- but here's what I've tested to work in my own app for reference

rrutsche commented 6 years ago

Thanks for the pull request. I never worked with srcset before. I just read that it is often used in combination with sizes. Does it make sense to also add this attribute?

AnalogMemory commented 6 years ago

Adding a sizes attribute would be ideal

rrutsche commented 6 years ago

@carterchung I merged your pull request and also added the new prop to the state update in loadImage and did the same for bgImageSizes attribute. I hope this is working for you now. Feel free to write me if there is something missing.

regards

carterchung commented 6 years ago

Awesome, thanks @RRutsche!