Closed JonasBa closed 1 month ago
Latest commit: 57ed19c1137f7f2d0fc4ee42695df97bdd505dae
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Good catch Jonas, could you add a changeset, then I'll merge it
@Juice10 sounds good, I just added the patch changeset. Let me know if there is anything else I can do
I think there is something up with gh ci, that check if failing on a network timeout
@Juice10 Mind restarting CI here, I cant seem to be able to trigger it (unless you want me to push an empty commit here)
@JonasBa sure!
While looking at some profiles on an adjacent PR, I noticed that we were spending a lot of time inside isParentRemoved.
I added a benchmark to cover a new deep tree test.
Largest change is on the deep tree benchmark I added which went from 475.5 to 377.4ms, the rest looks more or less the same.
Before
console.log ┌─────────┬────────────────────────────────────────────────────────┬───────────────────────────────────────────┬─────────────────────┬───────┬──────────┬────────────────────────────────────────────────────┐ │ (index) │ title │ html │ eval │ times │ duration │ durations │ ├─────────┼────────────────────────────────────────────────────────┼───────────────────────────────────────────┼─────────────────────┼───────┼──────────┼────────────────────────────────────────────────────┤ │ 0 │ 'create 1000x 1 DOM nodes with deeply nested children' │ 'benchmark-dom-mutation-deep-nested.html' │ 'window.workload()' │ 10 │ 475.5 │ '481, 461, 488, 477, 470, 514, 449, 471, 472, 472' │ └─────────┴────────────────────────────────────────────────────────┴───────────────────────────────────────────┴─────────────────────┴───────┴──────────┴────────────────────────────────────────────────────┘
After console.log ┌─────────┬────────────────────────────────┬───────┬────────────────────┬────────────────────┐ │ (index) │ title │ times │ duration │ durations │ ├─────────┼────────────────────────────────┼───────┼────────────────────┼────────────────────┤ │ 0 │ 'append 70 x 70 x 70 elements' │ 3 │ 1320.3333333333333 │ '1366, 1299, 1296' │ └─────────┴────────────────────────────────┴───────┴────────────────────┴────────────────────┘
console.log ┌─────────┬────────────────────────────────────────────────────────┬───────────────────────────────────────────┬─────────────────────┬───────┬──────────┬────────────────────────────────────────────────────┐ │ (index) │ title │ html │ eval │ times │ duration │ durations │ ├─────────┼────────────────────────────────────────────────────────┼───────────────────────────────────────────┼─────────────────────┼───────┼──────────┼────────────────────────────────────────────────────┤ │ 0 │ 'create 1000x 1 DOM nodes with deeply nested children' │ 'benchmark-dom-mutation-deep-nested.html' │ 'window.workload()' │ 10 │ 377.4 │ '385, 369, 398, 366, 373, 369, 376, 410, 359, 369' │ └─────────┴────────────────────────────────────────────────────────┴───────────────────────────────────────────┴─────────────────────┴───────┴──────────┴────────────────────────────────────────────────────┘