search

rrweb-io / rrweb

record and replay the web
https://www.rrweb.io/
MIT License
15.9k stars 1.38k forks source link

fix: pass maskInputFn to snapshot #1490

Closed lewgordon-amplitude closed 4 weeks ago

lewgordon-amplitude commented 1 month ago

I saw the same change proposed in https://github.com/rrweb-io/rrweb/pull/1386, but not merged. I can't see why the tests were failing. I'd like to help get this through.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: f67cd4a59f3cc0007ea158794b253e2841ac5bf8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

eoghanmurray commented 4 weeks ago

Thanks @lewgordon-amplitude I'll close this as a duplicate of the other one you mention; I think that one is close to merging, I've just got a few questions on it.

lewgordon-amplitude commented 4 weeks ago

Sounds good, thanks @eoghanmurray