search

rrwick / Deepbinner

a signal-level demultiplexer for Oxford Nanopore reads
GNU General Public License v3.0
124 stars 23 forks source link

Tests failing #24

Open mbhall88 opened 5 years ago

mbhall88 commented 5 years ago

Hey @rrwick ,

I just tried running the tests and some of them failed.

The version of python I was running on is 3.5.2

I ran tests with python3 -m unittest from the project root directory.

In total 7 tests failed. All with the same message - an example is below:

======================================================================
ERROR: test_find_all_fast5s_verbose (tests.test_load_fast5s.TestLoadFast5s)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/Deepbinner/tests/test_load_fast5s.py", line 37, in test_find_all_fast5s_verbose
    fast5s = deepbinner.load_fast5s.find_all_fast5s(self.fast5_dir, verbose=True)
  File "/root/Deepbinner/deepbinner/load_fast5s.py", line 57, in find_all_fast5s
    for dir_name, _, filenames in os.walk(directory):
  File "/usr/lib/python3.5/os.py", line 371, in walk
    scandir_it = scandir(top)
TypeError: scandir: illegal type for path parameter

Seems maybe os.scandir doesn't take a pathlib.Path object in python 3.5 maybe?