rrwick / Minipolish

A tool for Racon polishing of miniasm assemblies
GNU General Public License v3.0
73 stars 7 forks source link

default thread value #11

Open EricDeveaud opened 2 years ago

EricDeveaud commented 2 years ago

Hello

minipolish/misc.py uses multiprocessing.cpu_count() to ge the max value of threads. in


def get_default_thread_count():
    return min(multiprocessing.cpu_count(), 16)```

but multiprocessing.cpu_count() is the number of cpu in the machine. But this is not the same as the number of cpu available to the process. For example, you can run in a taskset context or a batch scheduler like slurm.

see:

$ nproc
96
$ taskset -c 1 nproc
1
$ taskset -c 1 python3 -c "import multiprocessing; print(multiprocessing.cpu_count())"
96

I would suggest to use len(os.sched_getaffinity(0)) instead of multiprocessing.cpu_count()

$ python3 -c "import os; print(len(os.sched_getaffinity(0)))"
96
$ taskset -c 1 python3 -c "import os; print(len(os.sched_getaffinity(0)))"
1

regards