search

rrwick / Porechop

adapter trimmer for Oxford Nanopore reads
GNU General Public License v3.0
335 stars 125 forks source link

Add Python 2.7 Compatibility #6

Closed scottgigante closed 7 years ago

scottgigante commented 7 years ago

Hi Ryan,

For those of us stuck in the past, I've added Python 2.7 compatibility. I've incidentally added a .travis.yml file to test against multiple versions of Python at once, but I can delete this from the PR if you like.

Cheers, Scott

rrwick commented 7 years ago

Hmmm, I hate to be stubborn, but I'm inclined to leave Porechop as Python 3 only. Is there a strong reason for maintain compatibility with both? For a code library, I can understand the value in supporting 2 and 3. But for a command line tool? Can't people just install Python 3? Quit living in the past! :smile:

I'm also being lazy and don't feel like testing everything in both, thinking about whether a module is available in 2, whether I need a special import, etc. I've been using Python 3 for a while now and am used to it.

scottgigante commented 7 years ago

Haha no stress - I was having trouble with compilation on my super finicky server, but I'll just sit over here in the past with my Python 2.7 implementation, and if anyone wants it they can clone my fork.

Great tool, by the way - thanks!