search

rrwick / Porechop

adapter trimmer for Oxford Nanopore reads
GNU General Public License v3.0
322 stars 123 forks source link

Fails to build with GCC 7 #76

Open sjackman opened 5 years ago

sjackman commented 5 years ago 
    porechop/include/seqan/system/file_sync.h: In member function 'bool seqan::File<seqan::Sync<TSpec> >::openTemp(int)':
    porechop/include/seqan/system/file_sync.h:337:25: error: call of overloaded 'empty(std::__cxx11::string&)' is ambiguous
             if (empty(tmpDir))
                             ^

See https://github.com/bioconda/bioconda-recipes/pull/11399 and https://circleci.com/gh/bioconda/bioconda-recipes/30016

e73kiel commented 5 years ago

OS=Centos 7.6 Python version=Python 3.6.3 gcc version=gcc 7.3.0

I updated

Porechop/porechop/include/seqan with seqan/include/seqan/

and installation finished without error.

dpryan79 commented 4 years ago

This can partially be solved by using a more recent seqan, but that results in a couple failed unit tests:

https://circleci.com/gh/bioconda/bioconda-recipes/69713

See https://github.com/bioconda/bioconda-recipes/pull/16212 for an example. I'm not sure about the changes in the seqan versions and how those relate to this.