rryqszq4 / ngx-php

ngx-php - Embedded php7 or php8 scripting language for nginx module. Mainline development version of the ngx-php.
BSD 2-Clause "Simplified" License
582 stars 56 forks source link

Ngx-PHP7 Compilation improvements and Prebuilt modules #131

Open soulteary opened 2 years ago

soulteary commented 2 years ago

I think this project is a very good project, so that Nginx can do a lot more.

However, it may be too long for the project to be submitted for testing by anyone other than the author, and the default project cannot be built.

For this I submitted a small improvement: https://github.com/rryqszq4/ngx_php7/pull/130

In order to use it more efficiently, I pre-built it: https://github.com/nginx-with-docker/ngx_http_php_module And adjusted the build image and script, so that this module can be built locally with each newly launched version of nginx.

If the author thinks this method will be better, I can submit a PR with improved build image at a later date, like this: https://github.com/nginx-with-docker/ngx_http_php_module/blob/main/docker/master/Dockerfile.alpine

I believe this can greatly reduce the compilation problems encountered by various users. @rryqszq4

The image based on the latest code base can be downloaded from here:

docker pull soulteary/prebuilt-nginx-modules:ngx-1.21.1-php-master-alpine

If anyone has a need, I will add a pre-built image of the Debian version.

jobs-git commented 2 years ago

Pre built can be untrusted, what if add a check of version then autorecompile if needed?

soulteary commented 2 years ago

No one has time to persecute you, especially based on open source code, you can always recreate the pre-built products yourself.