search

rryqszq4 / ngx-php

ngx-php - Embedded php7 or php8 scripting language for nginx module. Mainline development version of the ngx-php.
BSD 2-Clause "Simplified" License
582 stars 56 forks source link

Disable tests with Ubuntu 22.04 #181

Closed joanhey closed 7 months ago

joanhey commented 7 months ago

It is working OK with Ubuntu 22.04, but fail the tests.

Till we fix the tests, will be disabled, but we can merge in the main branch.

Only test Unbuntu 22.04, Nginx 1.25.3 and PHP 8.3 in the dev branch for now.

rryqszq4 commented 7 months ago

Just fixd request body larger than 10kb. https://github.com/rryqszq4/ngx-php/commit/42fb4ff9a3e1b571f0a2b45373b7743391d65c0d

joanhey commented 7 months ago

Tests passing https://github.com/rryqszq4/ngx-php/actions/runs/7100269208/job/19325997338

joanhey commented 7 months ago

After merge in master, and create a new release, you can close issues:

And check other issues, if we can close them.

rryqszq4 commented 7 months ago

After merge in master, and create a new release, you can close issues:

And check other issues, if we can close them.

OK, I want to ready merge this request.

rryqszq4 commented 7 months ago

https://github.com/rryqszq4/ngx-php/actions/runs/7100525393/job/19326790601 was failed.

joanhey commented 7 months ago

Yes, but this test only run in the dev branch, not in the others branches. When we fix tests with Ubuntu 22.04, they will be added to the other branches.

joanhey commented 7 months ago

https://github.com/rryqszq4/ngx-php/actions/runs/7100525393/workflow#L4-L6

rryqszq4 commented 7 months ago

Yes, but this test only run in the dev branch, not in the others branches. When we fix tests with Ubuntu 22.04, they will be added to the other branches.

I understand.

joanhey commented 7 months ago

And I'm creating pestPHP test to use in any PHP runtime. I created it for my project Adapterman, but now I'm separating to use it alone.

Later I'll add to ngx-php. So we will have another test, using PHP.

With Adapterman: https://github.com/joanhey/AdapterMan/actions/runs/6202720452/job/16842037726#step:5:133

The repo for the stand alone is in progress in https://github.com/joanhey/TestMan So the same tests, can be run in any php runtime. Now every runtime create its own tests. And it will be easier have feedback from other runtimes, as one issue in one can affect another runtimes.

And also started a new repo ngx-adapter, it's an Adapterman version for use with ngx-php. To use any php fw or app that use front-controller with ngx-php, without touch 1 line of code.