search

rryqszq4 / ngx-php

ngx-php - Embedded php7 or php8 scripting language for nginx module. Mainline development version of the ngx-php.
BSD 2-Clause "Simplified" License
642 stars 55 forks source link

[pr] release version to 0.0.28 #182

Closed rryqszq4 closed 11 months ago

rryqszq4 commented 11 months ago

@joanhey Merge into branch master.

joanhey commented 11 months ago

Mege it !! The tests will pass.

When it's merged it will not run the dev test, and later we can edit these comments.

joanhey commented 11 months ago

We need to change the badge in the master branch to:

[![Build](https://github.com/rryqszq4/ngx-php/actions/workflows/build.yml/badge.svg?branch=master)](https://github.com/rryqszq4/ngx-php/actions/workflows/build.yml)

Now it's showing for any branch. And the dev need to fail some times, but don't affect the master branch.

joanhey commented 11 months ago

We can change the badget later, before create the tag for v0.0.28.

joanhey commented 11 months ago

We need to change the badget, only in the master branch.

joanhey commented 11 months ago

It is not necessary, I think that will use the badget from the default branch. Wait to check it before change it.

joanhey commented 11 months ago

image

Now it's poiting to a workflow that don't exist.

joanhey commented 11 months ago

Also change the typo image