rs-pro / rails_admin_settings

Rails Admin Settings: App Settings management via RailsAdmin
https://gitlab.com/rocket-science/rails_admin_settings
MIT License
29 stars 21 forks source link

adding boolean as a data type #2

Closed teonimesic closed 8 years ago

teonimesic commented 10 years ago

adding a 'boolean' data type that can be edited with a check box.

I made boolean value to be either 'true' or 'false', since the raw field is typecast as a String.

I've tried to remove the String typecast before from the raw field, but it resulted in so many conflicts with Integer and YAML types that I decided to just use 'true' and 'false' for boolean values and leave the typecast on raw field as is.

glebtv commented 10 years ago

I agree that a proper boolean field is good to have, but we usually just use enabled field for boolean (and not use the value). Is there any reason you can't you use it?