rs-station / careless

Merge X-ray diffraction data with Wilson's priors, variational inference, and metadata
MIT License
16 stars 6 forks source link

treat sys absences in dw prior #105

Closed kmdalton closed 1 year ago

kmdalton commented 1 year ago

This improves the handling of systematic absences for the double-Wilson prior.

codecov-commenter commented 1 year ago

Codecov Report

Merging #105 (32d9ee0) into main (bce9dc9) will decrease coverage by 0.16%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   82.81%   82.65%   -0.16%     
==========================================
  Files          46       46              
  Lines        1967     1972       +5     
==========================================
+ Hits         1629     1630       +1     
- Misses        338      342       +4     
Flag Coverage Δ
unittests 82.65% <33.33%> (-0.16%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
careless/models/priors/wilson.py 45.34% <0.00%> (-0.54%) :arrow_down:
careless/io/asu.py 91.66% <50.00%> (-3.93%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

DHekstra commented 1 year ago

I can test this next week with the THz data.

kmdalton commented 1 year ago

@DHekstra, can i merged this PR?

DHekstra commented 1 year ago

started testing, will let you know asap

kmdalton commented 1 year ago

@DHekstra, is it okay to merge this?

DHekstra commented 1 year ago

OK, this seems to work as intended. I reran analysis of the (e35) PDZ2 data with results highly similar to before.