search

rs-station / careless

Merge X-ray diffraction data with Wilson's priors, variational inference, and metadata
MIT License
16 stars 6 forks source link

fix order of chained bijector #122

Closed kmdalton closed 1 year ago

kmdalton commented 1 year ago

tfb.Chain applies bijectors from right to left. When it comes to the scale parameter of the truncated normal posteriors, the shift was being applied before the exp.

codecov-commenter commented 1 year ago

Codecov Report

Merging #122 (dcda8ff) into main (28975fc) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   78.82%   78.82%           
=======================================
  Files          49       49           
  Lines        2135     2135           
=======================================
  Hits         1683     1683           
  Misses        452      452
Flag Coverage Δ
unittests 78.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
careless/models/merging/surrogate_posteriors.py 89.01% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more