Open dennisbrookner opened 1 year ago
Merging #137 (2d07ad9) into main (4f25d47) will increase coverage by
0.03%
. Report is 1 commits behind head on main. The diff coverage is37.14%
.
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 79.09% 79.12% +0.03%
==========================================
Files 52 52
Lines 2353 2362 +9
==========================================
+ Hits 1861 1869 +8
- Misses 492 493 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 79.12% <37.14%> (+0.03%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files Changed | Coverage Δ | |
---|---|---|
careless/stats/prior_b.py | 0.00% <0.00%> (ø) |
|
careless/stats/rescale.py | 0.00% <0.00%> (ø) |
|
careless/stats/completeness.py | 87.87% <33.33%> (+0.37%) |
:arrow_up: |
careless/stats/filter_by_image_cc.py | 89.55% <33.33%> (+0.15%) |
:arrow_up: |
careless/stats/rsplit.py | 90.41% <33.33%> (+0.13%) |
:arrow_up: |
careless/stats/ccanom.py | 88.75% <50.00%> (+0.14%) |
:arrow_up: |
careless/stats/cchalf.py | 91.02% <50.00%> (+0.11%) |
:arrow_up: |
careless/stats/ccpred.py | 92.00% <50.00%> (+0.10%) |
:arrow_up: |
careless/stats/history.py | 89.65% <50.00%> (+3.44%) |
:arrow_up: |
careless/stats/image_cc.py | 89.83% <50.00%> (+0.17%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This looks like a great start. It'll take me some time to review. Let me address some of these action items:
tf
installation instructions would be automatically pulled into the page. careless.image_cc
and careless.xds2mtz
?rs-booster
for difference maps. I think stream2mtz
can just go away wholesale, because careless
just supports .stream
files now. Feel free to remove this stuff. In general, the scripts directory is really just a dumping ground for code snippets that probably should be in rs-booster or the stats / io submodules. I'd be comfortable just deleting the whole directory and sorting it out later.
It finally happened, I went rogue and built docs for careless! No rush to get this merged in, and theres's still a little work to be done, as outlined below.
Changes in this PR
docs/
folder containing fairly boilerplateconf.py
,MAKEFILE
, andmake.bat
files, along with:index.md
, the contents of which are grabbed from the repo READMEcareless.md
, documenting the CLI for the core careless functionstats.md
, documenting all other command-line utilities included in carelesscareless.filter_by_image_cc
, which didn't work for reasons that I don't understand.double_wilson.md
, a description of the double Wilson algorithm that was already present in the repo.autoprogram
. See the issue I raised there for details:test_docs.yml
andbuild_docs.yml
. The former runs on any pull request to main and checks that the website builds; the latter runs on any push to main, and builds and deploys the websitesetup.py
topyproject.toml
. I originally intended to not do this, but as I got deeper into these changes, it became the path of least resistance.[docs]
and.[test]
installation optionssetup.py
-based installation is now no longer supported 😢build.yml
andpublish.yml
were updated accordingly.Action items before merging
careless.filter_by_image_cc
gives a weird segfault. Or don't, I guess. I don't know how critical this is.setup.py
-->pyproject.toml
transition, and if it was, add it back in. For example:LONG_DESCRIPTION
to this:
def main(): run_analysis(parse_arguments().parse_args())