codecov-commenter
commented
9 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
19b4ca3) 78.88% compared to head (7aae60f) 78.88%. Report is 1 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #146 +/- ## ======================================= Coverage 78.88% 78.88% ======================================= Files 52 52 Lines 2344 2344 ======================================= Hits 1849 1849 Misses 495 495 ``` | [Flag](https://app.codecov.io/gh/rs-station/careless/pull/146/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rs-station) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/rs-station/careless/pull/146/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rs-station) | `78.88% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rs-station#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR attempts to address #145. The root cause of this bug was that calculating reflection resolution from the harmonic index and principle reflection resolution is not as accurate as using the miller indices and cell.