search

rs-station / careless

Merge X-ray diffraction data with Wilson's priors, variational inference, and metadata
MIT License
16 stars 6 forks source link

add --disable-progress-bar flag #99

Closed kmdalton closed 1 year ago

kmdalton commented 1 year ago

Add a flag to disable the progress bar and prevent cluttering stderr

kmdalton commented 1 year ago

Address #97

@DHekstra, please review the changes and make sure they do what you want.

codecov-commenter commented 1 year ago

Codecov Report

Merging #99 (b954ce2) into main (93fee3b) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   82.23%   82.25%   +0.01%     
==========================================
  Files          45       45              
  Lines        1880     1882       +2     
==========================================
+ Hits         1546     1548       +2     
  Misses        334      334
Flag Coverage Δ
unittests 82.25% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
careless/args/common.py 100.00% <ø> (ø)
careless/careless.py 62.96% <100.00%> (+0.46%) :arrow_up:
careless/models/merging/variational.py 84.00% <100.00%> (+0.16%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

DHekstra commented 1 year ago

Yes, that looks good. I do indeed log the stderr for troubleshooting because they are all slurm jobs. The files become very big.