rs-station / laue-dials

A package for analyzing Laue x-ray crystallography data using the DIALS framework.
https://rs-station.github.io/laue-dials/
MIT License
5 stars 3 forks source link

nproc issue? #41

Closed DHekstra closed 11 months ago

DHekstra commented 11 months ago

For

the following fails in the CHESS HEWL tutorial

%%time
%%bash

laue.optimize_indexing stills* \
output.experiments="optimized.expt" \
output.reflections="optimized.refl" \
output.log="laue.optimize_indexing.log" \
wavelengths.lam_min=0.76 \
wavelengths.lam_max=0.81 \
reciprocal_grid.d_min=1.8 \
nproc=8

with error

Sorry: Unknown command line parameter definition: nproc = 8

The same cell completes just fine when omitting the last line.

DHekstra commented 11 months ago

Ah, it succeeds with

%%time
%%bash

laue.optimize_indexing stills* \
output.experiments="optimized.expt" \
output.reflections="optimized.refl" \
output.log="laue.optimize_indexing.log" \
wavelengths.lam_min=0.76 \
wavelengths.lam_max=0.81 \
reciprocal_grid.d_min=1.8 \
n_proc=8

so it's just the underscore in n_proc.

PrinceWalnut commented 11 months ago

Yes, this was a recent issue that just got fixed. It will be consistent in the next release and will be nproc, which is what DIALS uses for its commands.