search

rs-station / matchmaps

https://rs-station.github.io/matchmaps/
Other
2 stars 0 forks source link

Suppress error where scaleit fails on non-isomorphous inputs #44

Closed dennisbrookner closed 6 months ago

dennisbrookner commented 6 months ago

This PR fixes the error raised in #43 wherein inputs which rs.concat flags as non-isomorphous will throw an error. Now, poorly isomorphous inputs can be used without issue.

Please note that this PR relies on the recent update to rs-booster which adds an --ignore-isomorphism option to rs.scaleit. Accordingly, I have tied the rs-booster dependency to the github development version, rather than the latest PyPI release. This also required setting the allow-direct-references = true option in pyproject.toml. When the rs-booster change makes it to PyPI, I will update this package accordingly.

While a fresh installation should pull the correct rs-booster version, I cannot guarantee that a simple pip install --upgrade matchmaps in an existing environment will do so. It may be necessary to explicitly call pip install git+https://github.com/rs-station/rs-booster.git in your environment.

To check if you have the correct version, just type rs.scaleit -h; if the help message includes the --ignore-isomorphism flag, you're good to go; if not, you need to update!