search

rs-station / reciprocalspaceship

Tools for exploring reciprocal space
https://rs-station.github.io/reciprocalspaceship/
MIT License
28 stars 12 forks source link

Add python 3.10 to test suite for github actions #101

Closed JBGreisman closed 2 years ago

JBGreisman commented 2 years ago

Looking ahead, it makes sense to include this in our test suite to preemptively catch any issues

JBGreisman commented 2 years ago

Blocked by https://github.com/numpy/numpy/issues/20039 for now.

JBGreisman commented 2 years ago

This PR now seems good to go to me. The only problem is that pytorch, which is a requirement in our [dev] build does not support python3.10 yet. As such, a call to pip install -e .[dev] would currently fail if called using python3.10.

I'm not sure if the above failure mode should keep us from updating to support python 3.10 though.

codecov-commenter commented 2 years ago

Codecov Report

Merging #101 (eb41bc8) into main (1c180ae) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          41       41           
  Lines        1571     1571           
=======================================
  Hits         1551     1551           
  Misses         20       20
Flag Coverage Δ
unittests 98.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c180ae...eb41bc8. Read the comment docs.