search

rs-station / reciprocalspaceship

Tools for exploring reciprocal space
https://rs-station.github.io/reciprocalspaceship/
MIT License
28 stars 12 forks source link

Defer pytorch installation to example notebook to speed up binder launch #125

Closed JBGreisman closed 2 years ago

JBGreisman commented 2 years ago

PyTorch is a very large package, and it seems likely to be the culprit for slowing down the binder launch (regardless of whether a cached docker image is found; #123). This PR defers installation of pytorch to the relevant example notebook. This should decrease the size of the docker image and speed things up, while still ensuring the "robust loss function" example runs.

codecov-commenter commented 2 years ago

Codecov Report

Merging #125 (a6b38a5) into main (d6a3753) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          41       41           
  Lines        1571     1571           
=======================================
  Hits         1551     1551           
  Misses         20       20
Flag Coverage Δ
unittests 98.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6a3753...a6b38a5. Read the comment docs.