Closed dennisbrookner closed 2 years ago
Merging #128 (624dddd) into main (1dd4e98) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 41 41
Lines 1571 1574 +3
=======================================
+ Hits 1551 1554 +3
Misses 20 20
Flag | Coverage Δ | |
---|---|---|
unittests | 98.72% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
reciprocalspaceship/dataset.py | 98.07% <100.00%> (+0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1dd4e98...624dddd. Read the comment docs.
This was pretty straightforward. Now, if you attempt to call
DataSet.stack_anomalous()
on a dataset containing columns such asI
,I(+)
, andI(-)
, you are greeted with the error message:I also added
test_stack_anomalous_duplicates()
totest_dataset_anomalous.py
to verify this behavior.Minor reordering
In the previous version of
DataSet.stack_anomalous()
, the line:comes after the following:
I was concerned that if I didn't check for bad labels until these four lines had already been run, that when the function exits with an error, the
DataSet
might still get modified without the user realizing? I'm not entirely sure if that's how things work, but in any event, I reordered things. Now, the labels are checked for potential duplicates before theDataSet
is modified.A random and annoying thing that I changed
Spyder astutely pointed out to me that several tests in
test_dataset_anomalous.py
contained things like:but never actually access the
result
. I changed these instances toetc. This is totally unrelated to this PR, so I'm happy to take this out if making this change here is annoying for code/version organization purposes.