search

rs-station / reciprocalspaceship

Tools for exploring reciprocal space
https://rs-station.github.io/reciprocalspaceship/
MIT License
28 stars 12 forks source link

Allow integer-backed columns with NaNs to be converted to float dtype #145

Closed JBGreisman closed 2 years ago

JBGreisman commented 2 years ago

This PR addresses #144, allowing integer-backed column types containing NaNs to be converted to float ndarrays.

Importantly, this ensures that phenix output MTZs can be "round-trip" read/written, and converted to/from gemmi

codecov-commenter commented 2 years ago

Codecov Report

Merging #145 (0d242b1) into main (05c0057) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   98.48%   98.46%   -0.02%     
==========================================
  Files          43       43              
  Lines        1712     1696      -16     
==========================================
- Hits         1686     1670      -16     
  Misses         26       26
Flag Coverage Δ
unittests 98.46% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
reciprocalspaceship/dtypes/base.py 94.73% <100.00%> (-0.76%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05c0057...0d242b1. Read the comment docs.