search

rs-station / reciprocalspaceship

Tools for exploring reciprocal space
https://rs-station.github.io/reciprocalspaceship/
MIT License
28 stars 12 forks source link

Remove `DataSet.append()` due to upcoming deprecation in Pandas #149

Closed JBGreisman closed 2 years ago

JBGreisman commented 2 years ago

This PR fixes #146 to remove the overloaded function, DataSet.append(), and any uses of it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #149 (c040f92) into main (f7d2a2c) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   98.46%   98.45%   -0.02%     
==========================================
  Files          43       43              
  Lines        1696     1681      -15     
==========================================
- Hits         1670     1655      -15     
  Misses         26       26
Flag Coverage Δ
unittests 98.45% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
reciprocalspaceship/concat.py 100.00% <ø> (ø)
reciprocalspaceship/dataset.py 98.00% <100.00%> (-0.08%) :arrow_down:
reciprocalspaceship/utils/stats.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7d2a2c...c040f92. Read the comment docs.