Closed dennisbrookner closed 2 years ago
Sorry for making a huge mess of this! I'll fix it tomorrow
sounds good -- ping me when you're to have this looked at
This is now functional! @JBGreisman let me know if I'm handling input types correctly; it seemed consistent with other similar functions to accept lists, numpy
arrays, and rs.DataSeries
.
I am going to make the changes above, and push them to a new branch intensities-clean
. This is hopefully the easier path than trying to untangle the above PR.
See #156
@dennisbrookner Can this be closed now that a new PR has been started?
Yes, closing this
I think this should do it, but let me know if there are any functionality and/or style things I'm missing.