pushing intensity.py and associated test

rs-station / reciprocalspaceship

Tools for exploring reciprocal space

https://rs-station.github.io/reciprocalspaceship/

MIT License

28 stars 12 forks source link

pushing intensity.py and associated test #151

Closed dennisbrookner closed 2 years ago

dennisbrookner commented 2 years ago

I think this should do it, but let me know if there are any functionality and/or style things I'm missing.

dennisbrookner commented 2 years ago

Sorry for making a huge mess of this! I'll fix it tomorrow

JBGreisman commented 2 years ago

sounds good -- ping me when you're to have this looked at

dennisbrookner commented 2 years ago

This is now functional! @JBGreisman let me know if I'm handling input types correctly; it seemed consistent with other similar functions to accept lists, numpy arrays, and rs.DataSeries.

dennisbrookner commented 2 years ago

I am going to make the changes above, and push them to a new branch intensities-clean. This is hopefully the easier path than trying to untangle the above PR.

dennisbrookner commented 2 years ago

See #156

JBGreisman commented 2 years ago

@dennisbrookner Can this be closed now that a new PR has been started?

dennisbrookner commented 2 years ago

Yes, closing this