I just ran into a situation where I had to manually rename columns before using rs.utils.copy_rfree(), because the function does not accept a custom column name. I think this call should become:
"R-free-flags", the Phenix naming convention, is a sensible default value for rfree_key.
I feel similarly, though less strongly, that rs.utils.add_rfree() should also accept the rfree_key argument. I think this is relevant to the changes proposed in #154; I'm raising this as a separate issue because it is a quicker fix that I can tackle first.
I just ran into a situation where I had to manually rename columns before using
rs.utils.copy_rfree()
, because the function does not accept a custom column name. I think this call should become:"R-free-flags"
, the Phenix naming convention, is a sensible default value forrfree_key
.I feel similarly, though less strongly, that
rs.utils.add_rfree()
should also accept therfree_key
argument. I think this is relevant to the changes proposed in #154; I'm raising this as a separate issue because it is a quicker fix that I can tackle first.