Closed JBGreisman closed 2 years ago
Merging #160 (836f694) into main (6258b95) will decrease coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 98.46% 98.45% -0.01%
==========================================
Files 43 43
Lines 1697 1688 -9
==========================================
- Hits 1671 1662 -9
Misses 26 26
Flag | Coverage Δ | |
---|---|---|
unittests | 98.45% <100.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
reciprocalspaceship/utils/structurefactors.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6258b95...836f694. Read the comment docs.
This PR rewrites
rs.utils.compute_structurefactor_multiplicity()
to be implemented with methods provided by thegemmi.GroupOps
class. Originally, we had implemented this on our own to vectorize the calculation; however, a vectorized version of this calculation is now provided ingemmi
.