search

rs-station / reciprocalspaceship

Tools for exploring reciprocal space
https://rs-station.github.io/reciprocalspaceship/
MIT License
28 stars 11 forks source link

set maximum numpy version to <2.0 #256

Closed kmdalton closed 2 weeks ago

kmdalton commented 2 weeks ago

numpy version 2.0 is breaking a bunch of tests. We should set a maximum version number until we can diagnose the issues.

To replicate:

conda create -yn rs python=3.11
conda activate rs
git clone https://github.com/rs-station/reciprocalspaceship
cd reciprocalspaceship
pip install -e . 
python setup.py test
JBGreisman commented 2 weeks ago

Do you still think this is necessary to include, or should we close this in favor of #258?

JBGreisman commented 2 weeks ago

I'm closing this in favor of #258 based on our off-line discussion