search

rs-station / reciprocalspaceship

Tools for exploring reciprocal space
https://rs-station.github.io/reciprocalspaceship/
MIT License
28 stars 12 forks source link

Compute the angular Ewald offset when loading streams #73

Closed kmdalton closed 3 years ago

kmdalton commented 3 years ago

This PR adds the angular Ewald offset to the metadata computed when loading stream files.

codecov-commenter commented 3 years ago

Codecov Report

Merging #73 (bcda297) into main (1f5a1e8) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          39       39           
  Lines        1470     1475    +5     
=======================================
+ Hits         1454     1459    +5     
  Misses         16       16
Flag Coverage Δ
unittests 98.91% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
reciprocalspaceship/dataset.py 99.06% <100.00%> (-0.01%) :arrow_down:
reciprocalspaceship/io/crystfel.py 94.77% <100.00%> (+0.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f5a1e8...bcda297. Read the comment docs.

JBGreisman commented 3 years ago

In addition to computing angular Ewald offsets, this PR also speeds up the loading of unmerged datasets