kmdalton commented 3 years ago

This pr adds a function to rs.utils for computing the angle between vectors in a numerically stable way. It also adds a test for said function. I also updated the crystfel stream file parser to use this new angle calculation in computing the angular ewald offset.

codecov-commenter commented 3 years ago

Codecov Report

Merging #75 (6e0c932) into main (1a1e089) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   98.91%   98.92%           
=======================================
  Files          39       40    +1     
  Lines        1477     1488   +11     
=======================================
+ Hits         1461     1472   +11     
  Misses         16       16

Flag	Coverage Δ
unittests	`98.92% <100.00%> (+<0.01%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
reciprocalspaceship/io/crystfel.py	`94.77% <100.00%> (ø)`
reciprocalspaceship/utils/__init__.py	`100.00% <100.00%> (ø)`
reciprocalspaceship/utils/math.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a1e089...6e0c932. Read the comment docs.

JBGreisman commented 3 years ago

I resolved the conflict (it was a simple thing), and will merge after CI finishes

rs-station / reciprocalspaceship

added an angle_between function to rs.utils #75

Codecov Report