search

rs-station / reciprocalspaceship

Tools for exploring reciprocal space
https://rs-station.github.io/reciprocalspaceship/
MIT License
28 stars 12 forks source link

use correct hkl resolution limits #83

Closed kmdalton closed 3 years ago

kmdalton commented 3 years ago

I had flipped the h,k,l axis limits when generating reciprocal cells which worked okay for low resolution tests with cube-ish cells. So, my test didn't catch it. I'll try to cook up a test later this week, but this is such an obvious bug that I will merge it first. I can probably relax the little oversampling I was doing in the original method as well.

codecov-commenter commented 3 years ago

Codecov Report

Merging #83 (4539f76) into main (eb19f86) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          40       40           
  Lines        1494     1494           
=======================================
  Hits         1478     1478           
  Misses         16       16
Flag Coverage Δ
unittests 98.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
reciprocalspaceship/utils/cell.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50655f0...4539f76. Read the comment docs.