search

rs-station / rs-booster

Useful scripts for analyzing diffraction
https://rs-station.github.io/rs-booster/
MIT License
3 stars 4 forks source link

pin `seaborn` version to 0.11.2 or less #37

Closed dennisbrookner closed 1 year ago

dennisbrookner commented 1 year ago

Pinning seaborn version to 0.11.2 because 0.12.0 or greater breaks plotting functionality for reasons currently unknown.

This PR probably should not be merged until we have an actual understanding of what has changed!

dennisbrookner commented 1 year ago

Just realized that this was never merged; I think as per the discussion in the issue linked above, just pinning the seaborn version is the best call.

kmdalton commented 1 year ago

apparently, @DHekstra has worked around this by explicitly coercing dtypes in the affected scripts. closing.

DHekstra commented 1 year ago

yes, that was just a side effect :)