I had a video with a rotation of -90 degrees, the preferredTransform is (a = 0, b = -1, c = 1, d = 0, tx = 0, ty = 720). The video was being scaled too much. Looking in to the code, videoAngleInDegree in buildDefaultVideoComposition gets assigned a value between -180 and 180 which becomes -90 for my video. However, the following comparison checks for 90 or 270 and my video doesn't match, resulting in a video that is scaled incorrectly.
Problem in above code seems to be that videoAngleInDegree can be -90 but not 270. Seems odd that this hasn't come up so I am probably missing something!
I've created a fork and will submit a pull request in case. Thanks!
I had a video with a rotation of -90 degrees, the preferredTransform is (a = 0, b = -1, c = 1, d = 0, tx = 0, ty = 720). The video was being scaled too much. Looking in to the code,
videoAngleInDegree
inbuildDefaultVideoComposition
gets assigned a value between -180 and 180 which becomes -90 for my video. However, the following comparison checks for 90 or 270 and my video doesn't match, resulting in a video that is scaled incorrectly.Problem in above code seems to be that
videoAngleInDegree
can be -90 but not 270. Seems odd that this hasn't come up so I am probably missing something!I've created a fork and will submit a pull request in case. Thanks!