search

rs / SDAVAssetExportSession

AVAssetExportSession drop-in replacement with customizable audio&video settings
MIT License
805 stars 212 forks source link

What's the expected default crop/resize behavior? #51

Open tony-pizza opened 8 years ago

tony-pizza commented 8 years ago

This is a question about the scope and design of this library, not an issue or question about the code itself.

Just curious, what is the expected crop and resize behavior (in the default videoComposition) when you pass in a AVVideoWidthKey and AVVideoHeightKey to videoSettings?

I know a couple cropping and resize issues have cropped up recently (pun intended) and I've run into some myself. It would be helpful if the intended default behavior was explicitly documented so that, for example, when black borders appear on the edges of a video I know whether that's expected behavior or a bug.

Also, I'm currently in the process of editing the default video composition code to suit my own needs. I'd be happy to PR when it's done, but I worry that I might "break" or change the current default behavior because I'm not really sure what it's supposed to be.

Relatedly, would supporting multiple crop/resize behaviors (selectable via the currently ignored AVVideoScalingModeKey in videoSettings, perhaps) be within the scope of this project?

Thanks!