rs / SDSegmentedControl

A drop-in remplacement for UISegmentedControl that mimic iOS 6 AppStore tab controls
MIT License
1.2k stars 180 forks source link

NSFoundationVersionNumber_iOS_6_1 does not exists on iOS 6 #54

Closed y0hnn closed 10 years ago

y0hnn commented 10 years ago

Hello !

My app won't build on XCode 4, because of SDSegmentedControl.m:105:45: Use of undeclared identifier 'NSFoundationVersionNumber_iOS_6_1'

NSFoundationVersionNumber_iOS_6_1 exists only on iOS 7, you should replace it with 993.00.

rs commented 10 years ago

I guess Apple won't accept apps compiled with old version of the tools/SDK, so what's the point?

y0hnn commented 10 years ago

Yeah, of course, but few peoples need to use XCode 4 :(. Could you just test with an ifdef, and if not defined set it with the right value ?

maxma86 commented 10 years ago

So, It won't work on blow ios 7? This is bad

rs commented 10 years ago

It will. Constants are resolved at compilation time.

KaiTeuber commented 10 years ago

A lot of people are still building with Xcode 4. Please add

ifndef NSFoundationVersionNumber_iOS_6_1

define NSFoundationVersionNumber_iOS_6_1 993.00

endif

rs commented 10 years ago

A lot? I don't see a single good reason not to upgrade. But if you insist, please send a pull request.

mickeyl commented 10 years ago

For the records: The single good reason not to upgrade is to get iOS6 compatibility mode on iOS7. Adding the iOS6 SDK into Xcode 5 is pretty flakey, it may work or may not, so if you want to build against iOS6 SDK, you better use Xcode 4. People working on larger projects are not able to upgrade their projects to iOS7 so fast.