search

rs / SafariOmnibar

Safari plugin to add Chrome like omnibar in Safari
http://hackemist.com/SafariOmnibar/
416 stars 30 forks source link

Handle I'm Feeling Lucky with ">" and "lucky" keyword shortcuts #66

Open Gurpartap opened 12 years ago

Gurpartap commented 12 years ago

Could have been just adding ">" to the plist. But didn't like that it wasn't performing the same as "?" (had to press a space).

Gurpartap commented 12 years ago

More about this pull request at: https://github.com/rs/SafariOmnibar/issues/64

rs commented 12 years ago

I think it would be better to add a key to service providers (i.e.: LuckyURLTemplate) instead of adding a new kind of search provider.

Gurpartap commented 12 years ago

I would too. But wouldn't it be messy to have too many keys and values for a single item? And more code to handle differentiating between search and feeling lucky request type.

rs commented 12 years ago

It's better to have several properties for a single provider than having to duplicate a provider. You shouldn't have feeling lucky url on a provider that haven't a search url right? In the future I also see a third url template for suggestions.