Adding Support For Docker / Docker Compose

rs / pushd

Blazing fast multi-protocol mobile and web push notification service

MIT License

1.16k stars 224 forks source link

Adding Support For Docker / Docker Compose #150

Closed christopherhein closed 6 years ago

christopherhein commented 8 years ago

I'm not sure if this is something you would like to bring into the core, I've been working on the side to make pushd run in a docker container this pr adds support for such a thing. Feel free to comment or close, but since I had done the work I figured I'd throw it out for feedback.

Why:

Enables developers to clone the repo and run docker-compose up -d able to start using the project
New sample env format for environment variables
New mechanisms for running tests by using docker-compose run api npm test

Thanks!

zokier commented 7 years ago

I find having a Dockerfile ready to go useful, but I'm not sure why @christopherhein decided to use CentOS, and an old version of that, as a base. I would think using official Node image would make more sense? I did that on my version.

christopherhein commented 7 years ago

Nice work @zokier do you want me to close mine and you can submit yours? Looks like you're using the same settings.coffee as well so we're 1005 compliant with each other…

zokier commented 7 years ago

Maybe @rs could chime in on what he would prefer?

rs commented 7 years ago

standard node image sounds better.

zokier commented 7 years ago

Ok. I want to make couple of tweaks, but then I make new pull request

christopherhein commented 6 years ago

Just cleaning up PRs sounds like I can close this?

rs commented 6 years ago

Sure