search

rs / xmux

xmux is a httprouter fork on top of xhandler (net/context aware)
Other
98 stars 11 forks source link

Go 1.8 context #9

Open fzerorubigd opened 7 years ago

fzerorubigd commented 7 years ago

The context package is now part of the standard library. there is a fix tool for rewriting this import path, I already done it in our build flow, but I think it's hard to decide to break the old builds, so I prefer to open an issue instead of a PR.

Is this any plan to move forward? another branch maybe, or not? this apply to xhandler and cors repo as well.

mattgen88 commented 7 years ago

I've gone through the code and updated xmux for the native contexts. If there's interest, I can work on contributing back. If this project is no longer maintained, I can work on other options.

rs commented 7 years ago

A PR is welcome.

dixonwille commented 7 years ago

@rs Would love to use this package for 1.8 but understand the consequences of upgrading. Close or merge at your leisure.

rs commented 7 years ago

xmux is a fork a httprouter with net/context support. As context is now in the stdlib and httprouter added support for it, there is no reason to use xmux with Go 1.8.