rs / zerolog

Zero Allocation JSON Logger
MIT License
10.39k stars 566 forks source link

Update example image to how it is currently rendered #596

Closed mitar closed 11 months ago

mitar commented 11 months ago

I noticed that the image is not how currently default console writer renders it.

The image was done using Ubuntu 20.04 using Gnome Terminal (I think default color settings).

I also made a JSONL file with log entries to be able to generate this in the future using the prettylog tool.

BTW, prettylog tool does not work on files, see my comment here.

rs commented 11 months ago

I added support for file input in 6e8841b038192f6cda1bf2652418cabc8928289c

mitar commented 11 months ago

Awesome!

mitar commented 11 months ago

One question. I noticed this because I wanted to compare how my changed colors compare to the default colors. I think my changed colors are much more readable. I wonder if this is something you would entertain that I make a PR and change also for defaults in zerolog:

Screenshot from 2023-10-13 14-12-06

Changes:

This makes debug and trace messages not stand out (they are all gray) while important ones do (especially important because there are generally many more debug ones).

rs commented 11 months ago

sure go ahead