search

rsachetto / MonoAlg3D_C

Extensible Monodomain simulator
MIT License
16 stars 12 forks source link

Fix on the GPU Forward Adaptive Euler function #33

Closed bergolho closed 3 years ago

bergolho commented 3 years ago

Hello Sachetto,

In this pull request I backtrack the code for the _solve_forward_euler_gpuadpt() function to a previous version. The main issue is related to the removal of a counter variable used in this function to avoid NaN values. In the current version I was facing some NaN troubles with some simulations when using the Trovato model and by reintroducing this counter variable I was able to solve these issues. Could you please check this function again ? Maybe there is a better way that we could tackle this problem instead of using a counter variable.

rsachetto commented 3 years ago

@bergolho This counter makes no sense anymore. Try to remove the dt from the [ode_solver] section in your .ini file. If you do so, the solver will not be bounded to a minimum dt and I think it will solver your problem.

rsachetto commented 3 years ago

Can you send me the config file that you are using please?