rsachetto / MonoAlg3D_C

Extensible Monodomain simulator
MIT License
16 stars 12 forks source link

First package of improvements Trovato/ToRORd #49

Closed bergolho closed 2 years ago

bergolho commented 2 years ago

Hello Sachetto,

In this pull request, I am sending the first package of improvements for the "Trovato" and "ToRORd_fkatp" model. The "ToRORd_fkatp_mixed_endo_epi_mid" model was rewritten following the original Matlab code from Jakub Tomek with the addition of the current modifiers in the common files. In a future pull request, I will send an update version of the model using these modifiers as extra parameters of the model, just like we did for the Ten & Tusscher model with fibrosis/acidosis. In addition, in this next pull request I will rewrite the Rush-Larsen equations fully on the source file, avoiding the boolean array that delays the computation time in GPU.

Secondly, this pull request brings a new script to plot ECG readings coming from the new Pseudo-ECG and an example of the save/restore state considering a sustained spiral wave generated by S1-S2 protocol.

Finally, I found a minor bug when using adaptive ODE methods. There was an instruction missing before line 328 in the "ode_solver.c" file. The "reltol" parameter was not set when the user specify its value in the configuration file.

Next week, I will try to work on new changes for the Purkinje solver(save/load state functions, extra data functions, PMJ file format).

bergolho commented 2 years ago

Solved the merging conflicts that appeared.