search

rsaenen / ngx-custom-validators

Angular custom directives for validation
129 stars 53 forks source link

Why the bootstrap 4 dependency? #31

Closed igor-pavlichenko closed 4 years ago

igor-pavlichenko commented 4 years ago

It's specified in the dependencies as "bootstrap": "^4.1.3",, what is it used for here?

For some reason it's breaking my angular 9 project that uses bootstrap-sass 3 in legacy code. It's related to sass exports/imports.

pedrotoch commented 4 years ago

Same happens to me as soon as I update ngx-custom-validators to latest version. Also using bootstrap-sass 3.

YZahringer commented 4 years ago

Same issue, with warning on npm audit

WARN bootstrap@4.4.1 requires a peer of jquery@1.9.1 - 3 but none is installed. You must install peer dependencies yourself.

WARN bootstrap@4.4.1 requires a peer of popper.js@^1.16.0 but none is installed. You must install peer dependencies yourself.
igor-pavlichenko commented 4 years ago

@rsaenen you are using bootstrap for development/testing purposes in /src/dev so my guess is that it should be moved back to devDependencies

Edit: I made a PR. Would be awesome if you could review it and release a new minor version. Let me know if there's anything wrong with it.

rsaenen commented 4 years ago

@igor-pavlichenko thanks a lot !

Released with 9.0.1