search

rsaenen / ngx-custom-validators

Angular custom directives for validation
129 stars 53 forks source link

incompatible with angular 9 #35

Closed techiesarav closed 4 years ago

techiesarav commented 4 years ago

IMPORTANT: For simple form validation i added ngx-custom-validators, but while building i am getting the below errors

node_modules/ngx-custom-validators/node_modules/@angular/core/core.d.ts:256:18 - error TS2314: Generic type 'ɵɵFactoryDef' requires 2 type argument(s).

Steps to reproduce and a minimal demo Try to add the below dev dependencies in package.json

"@angular/animations": "~9.0.1",
"@angular/common": "^9.0.1",
"@angular/compiler": "^9.0.1",
"@angular/core": "^9.0.1",
"@angular/fire": "0.0.0",
"@angular/forms": "^9.0.1",
"@angular/http": "^7.2.16",
"@angular/localize": "~9.0.1",
"@angular/platform-browser": "^9.0.1",
"@angular/platform-browser-dynamic": "^9.0.1",
"@angular/router": "^9.0.1",
"@ng-bootstrap/ng-bootstrap": "^6.1.0",
"angularfire2": "5.0.0-rc.4",
"bootstrap": "^4.4.1",
"firebase": "4.8.0",
"ngx-custom-validators": "^9.1.0",
"rxjs": "^6.5.5",
"rxjs-compat": "^6.5.5",
"tslib": "^1.10.0",
"zone.js": "^0.10.2"

Then try to run ng serve

Current behavior I am getting error in ngx-custom-validators because of some dependencies incompatibility

Expected/desired behavior

Environment information

techiesarav commented 4 years ago

The above issue is because of the dependency error and it is solved now.