search

rsagroup / rsatoolbox

Python library for Representational Similarity Analysis
MIT License
183 stars 38 forks source link

`RDMs.sort_by(reindex)` argument #375

Closed caiw closed 8 months ago

caiw commented 10 months ago

Adds a new reindex: bool argument to RDMs.sort_by(), default True, which resets the index after sorting.

@JasperVanDenBosch suggested that it also throw a depricationwarning, but I'm not sure what the policy is on this.

Fixes #358.

Some issues

If the RDMs has a pattern_descriptor named "reindex", this will upset the function. I'm not sure what to do about this, other than change the signature of sort_by().

JasperVanDenBosch commented 10 months ago

Let's just assume reindex is an unlikely descriptor name?

And I guess the warning would be a bit tricky to set up here.