Replace deprecated `convert_to_dataset()` with `time_as_observations()`

rsagroup / rsatoolbox

Python library for Representational Similarity Analysis

MIT License

188 stars 37 forks source link

Replace deprecated `convert_to_dataset()` with `time_as_observations()` #410

Closed qian-chu closed 3 months ago

qian-chu commented 3 months ago

TemporalDataset.convert_to_dataset() method got deprecated and replaced by TemporalDataset.time_as_observations() in https://github.com/rsagroup/rsatoolbox/pull/295. Yet convert_to_dataset() was still called on several occasions including calc_rdm_movie() and tests and demos. I replaced all such occurances to avoid triggering warnings.

HeikoSchuett commented 3 months ago

Thank you @qian-chu . This is certainly a sensible change and I don't seem any reason to wait. I'll merge this now.