search

rsalayo / OpeniT.Timesheet.Issues

This repository will host the issues ONLY for the original #TimesheetJS
0 stars 0 forks source link

The "delete" symbol doesn't really fit on pinned tasks #40

Closed cyborgar closed 6 years ago

cyborgar commented 7 years ago

This is clearly "nitpicking" but why not.

To me it seem more natural to have the "unpin" option tied to the "pinned" icon. I.e. clicking on "pinned" unpins a task instead of using the trashcan symbol. At least I tried to unpin a task that way the first time.

rsalayo commented 7 years ago

I actually planned to use the pinned icon from the start. But as you may have guessed, it doesn't look uniformed with the rest without the delete button. image Another way that I can think of is to hide all buttons and only shows up when user's hover.

cyborgar commented 7 years ago

Perhaps the "pin task" concept is wrong. And "create template" is more appropriate. You are actually duplicating and not really pinning existing entry.

  1. jun. 2017 04.39 skrev "Romeo Salayo" notifications@github.com:

I actually planned to use the pinned button from the start. But as you may have guessed, it doesn't look uniformed with the rest without the delete icon. [image: image] https://cloud.githubusercontent.com/assets/1053166/26749770/63f59f90-47d7-11e7-9a28-7403a6c22488.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rsalayo/OpeniT.Timesheet.Issues/issues/40#issuecomment-305943750, or mute the thread https://github.com/notifications/unsubscribe-auth/AHjez0vvGFjuWcqRYlR0u0g6G145N_gmks5sAMABgaJpZM4NuOp1 .